Thanks for creating the RC. Unfortunately, my vote is: -1 I checked: - Incubating in name : Ok - Hashes and Signatures : Ok - DISCLAIMER file : Ok - LICENSE file : Ok - NOTICE file : Not Ok [A] - CHANGELOG file : Not Ok [B] - ASF headers in source files : Not Ok [C] - Binary files : Not Ok [D] - Compile from source : Ok
Recommendation: [A] NOTICE file Please change 2017-2018 to 2017-2020 [B] CHANGELOG file Please add changelog for 0.15.0 (currently contains changelogs for only versions <= 0.14.0) [C] ASF headers in source files - Please fix 16 files with missing ASF headers - Please remove hidden files eg: .codecov_bash and .dockerignore - Please remove binary files - I have attached the RAT report with the email for your review. It should come out green [D] Binary files Please remove binary files Minor: Please file a ticket for javadocs warning if not already exists. Thanks, Abhishek On Mon, Aug 17, 2020 at 8:44 AM Hung Tran <[email protected]> wrote: > Hi, > > -1 on RC0. The binaries should be removed. That was brought up as an issue > in previously releases. > > Hung. > ________________________________ > From: Owen O'Malley <[email protected]> > Sent: Friday, August 14, 2020 10:22 AM > To: [email protected] <[email protected]> > Subject: Re: [VOTE] Apache Gobblin 0.15.0 release RC0 > > Again, not a blocker but there are a lot of javadoc warnings. :) > > On Fri, Aug 14, 2020 at 10:19 AM Owen O'Malley <[email protected]> > wrote: > > > I'm -1 on the RC. > > > > 1. The signatures & checksums are good. > > 2. The source tarball has some minor differences from the tag. (Since > > it isn't source code, that isn't a blocker.) > > 3. But I got two failed tests when I built on my laptop: > > > > DatabaseJobHistoryStoreV101Test. > > DatabaseJobHistoryStoreV103Test. > > > > .. Owen > > > > > > On Wed, Aug 12, 2020 at 4:08 PM Owen O'Malley <[email protected]> > > wrote: > > > >> I notice that the source tarball differs from the git tag. That seems > >> unfortunate. > >> > >> Only in incubator-gobblin-release-0.15.0-rc0: .github > >> Only in incubator-gobblin-release-0.15.0-rc0: .gitignore > >> Only in > >> > incubator-gobblin-release-0.15.0-rc0/gobblin-hive-registration/src/test/resources/test-hive-table/snapshot1: > >> .gitignore > >> Only in > >> > incubator-gobblin-release-0.15.0-rc0/gobblin-metrics-libs/gobblin-metrics: > >> .gitignore > >> Only in > >> incubator-gobblin-release-0.15.0-rc0/gobblin-modules/gobblin-couchbase: > >> .gitignore > >> Only in > >> > incubator-gobblin-release-0.15.0-rc0/gobblin-modules/gobblin-kafka-common/src/test/resources/_CONFIG_STORE/v1.0/data/tracking/Topic3: > >> .DS_Store > >> Only in > >> incubator-gobblin-release-0.15.0-rc0/gobblin-modules/gobblin-zuora: > >> .gitignore > >> Only in > >> apache-gobblin-incubating-sources-0.15.0/gobblin-test-utils/src/main: > >> gen-avro > >> Only in incubator-gobblin-release-0.15.0-rc0/gradle/wrapper: > >> gradle-wrapper.jar > >> diff -r apache-gobblin-incubating-sources-0.15.0/gradle.properties > >> incubator-gobblin-release-0.15.0-rc0/gradle.properties > >> 38c38 > >> < org.gradle.jvmargs=-Xms512m -Xmx4096m > >> \ No newline at end of file > >> --- > >> > org.gradle.jvmargs=-Xms512m -Xmx4096m > >> Only in incubator-gobblin-release-0.15.0-rc0: maven-sonatype > >> Only in incubator-gobblin-release-0.15.0-rc0: travis > >> > >> Although we should delete the .DS_Store from the git repository and > >> ensure that it is in the .gitignore. > >> > >> I did check the signatures and checksums of the source release. > >> > >> On Wed, Aug 12, 2020 at 3:54 PM Owen O'Malley <[email protected]> > >> wrote: > >> > >>> I generally recommend also including the link to the tag in github: > >>> > >>> > >>> > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fincubator-gobblin%2Freleases%2Ftag%2Frelease-0.15.0-rc0&data=02%7C01%7Chutran%40linkedin.com%7C51aaadd9fd824ba3194508d84076a3e2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637330225580801860&sdata=k%2BFh8TS9Vxfw8dWpkwQpq7eeHHCgBtp47M6QMv%2Fs3is%3D&reserved=0 > >>> > >>> .. Owen > >>> > >>> On Wed, Aug 12, 2020 at 3:32 PM Sudarshan Vasudevan > >>> <[email protected]> wrote: > >>> > >>>> Hi all, > >>>> > >>>> I'd like to call a vote to release Apache Gobblin 0.15.0 (Incubating). > >>>> > >>>> The source release candidate RC0 can be downloaded here: > >>>> > >>>> > >>>> > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fincubator%2Fgobblin%2Fapache-gobblin-incubating-0.15.0-rc0%2F&data=02%7C01%7Chutran%40linkedin.com%7C51aaadd9fd824ba3194508d84076a3e2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637330225580811816&sdata=Hp%2F3bzlRec8NmfVHrLPcRtUIpCgwHzxDeZosKi2r4Lw%3D&reserved=0 > >>>> < > >>>> > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fincubator%2Fgobblin%2Fapache-gobblin-incubating-0.12.0-rc0%2F&data=02%7C01%7Chutran%40linkedin.com%7C51aaadd9fd824ba3194508d84076a3e2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637330225580811816&sdata=JWNpyICDSTXs84y4ACS7b6Qdpj9mwsHxe%2BS0Aby3n3g%3D&reserved=0 > >>>> > > >>>> > >>>> The artifacts (i.e. JARs) corresponding to this release candidate can > be > >>>> found here: > >>>> > >>>> > >>>> > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapachegobblin-1009%2F&data=02%7C01%7Chutran%40linkedin.com%7C51aaadd9fd824ba3194508d84076a3e2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637330225580811816&sdata=9lo4ZJACfLxeL94cjCI2RKaCBsYHZGdH6DE0EAa9ZH4%3D&reserved=0 > >>>> < > >>>> > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapachegobblin-1000%2F&data=02%7C01%7Chutran%40linkedin.com%7C51aaadd9fd824ba3194508d84076a3e2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637330225580811816&sdata=7mRUNVo0QC%2FlYj4gHlLiYerKOib%2B5PKBmFVolugV7uk%3D&reserved=0 > >>>> > > >>>> > >>>> This has been signed with PGP key 7F4FC4D0, corresponding to > >>>> [email protected], which is included in the repository's KEYS file. > >>>> This > >>>> key can be found on keyservers, such as: > >>>> > >>>> > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fkeyserver.ubuntu.com%2Fpks%2Flookup%3Fsearch%3D0x7F4FC4D0%26fingerprint%3Don%26op%3Dindex&data=02%7C01%7Chutran%40linkedin.com%7C51aaadd9fd824ba3194508d84076a3e2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637330225580811816&sdata=be7w6pxMLfOpI8uB7MqfYbbmUYM3PRkavbckIVOqgJA%3D&reserved=0 > >>>> > >>>> > >>>> It is also listed here: > >>>> > >>>> > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeople.apache.org%2Fkeys%2Fcommitter%2Fsuvasude.asc&data=02%7C01%7Chutran%40linkedin.com%7C51aaadd9fd824ba3194508d84076a3e2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637330225580811816&sdata=69F1fIFq5FKPi2bkqam9Bt1lim2102bPa%2Fc5ofVpOAQ%3D&reserved=0 > >>>> > >>>> > >>>> The release candidate has been tagged with release-0.15.0-rc0. > >>>> I've also created a branch 0.15.0. > >>>> > >>>> For reference, here is a list of all closed JIRAs tagged with 0.15.0: > >>>> > >>>> > >>>> > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FGOBBLIN-48%3Fjql%3Dproject%2520%253D%2520GOBBLIN%2520AND%2520fixVersion%2520%253D%25200.15.0%2520AND%2520status%2520in%2520&data=02%7C01%7Chutran%40linkedin.com%7C51aaadd9fd824ba3194508d84076a3e2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637330225580811816&sdata=P2p1J5gaWkjVERjLgC9Qt85OSikrENzCozDQpsbtfZU%3D&reserved=0(Closed%2C%20Resolved)%20ORDER%20BY%20updatedDate%20DESC%2C%20createdDate%20DESC%2C%20status%20DESC%2C%20priority%20DESC > >>>> > >>>> > >>>> For a summary of the changes in this release, see: > >>>> > >>>> > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fincubator-gobblin%2Fblob%2F0.15.0%2FCHANGELOG.md&data=02%7C01%7Chutran%40linkedin.com%7C51aaadd9fd824ba3194508d84076a3e2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637330225580811816&sdata=axumMw1kW%2Fvk9jWecNAon8h0MV0lOb%2Bes0TnpIPNjdk%3D&reserved=0 > < > >>>> > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fincubator-gobblin%2Fblob%2F0.12.0%2FCHANGELOG.md&data=02%7C01%7Chutran%40linkedin.com%7C51aaadd9fd824ba3194508d84076a3e2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637330225580811816&sdata=8fQ3zFQAbMu0JAn4x7N1HFb84AjcvQoP39NLEslX39c%3D&reserved=0 > > > >>>> > >>>> Please review and vote. The vote will be open for 72 hours (ends on > >>>> Saturday, 15 August 2020, 5 PM PST). > >>>> > >>>> [ ] +1 approve > >>>> [ ] +0 no opinion > >>>> [ ] -1 disapprove (and reason why) > >>>> > >>>> My vote: +1 > >>>> > >>>> Thanks, > >>>> Sudarshan > >>>> > >>>> > >>>> > >>>> >
