[
https://issues.apache.org/jira/browse/GOBBLIN-1257?focusedWorklogId=480313&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-480313
]
ASF GitHub Bot logged work on GOBBLIN-1257:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Sep/20 17:33
Start Date: 08/Sep/20 17:33
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3097:
URL: https://github.com/apache/incubator-gobblin/pull/3097#discussion_r485086038
##########
File path: gobblin-compaction/build.gradle
##########
@@ -31,6 +31,7 @@ dependencies {
// with hive-exec-core in older version(1.0.1), we need to shadow
ord-mapreduce's transitive deps.
// and include direct orc-mapreduce library just as a compileOnly dependency
compileOnly externalDependency.orcMapreduce
+ compile externalDependency.orcTools
Review comment:
Since the utility class that allows users to run compaction locally is
not a unit test, I had it located in the src/main of gobblin-compaction module.
Also, this dependency will be needed at runtime, hence I chose "compile".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 480313)
Time Spent: 40m (was: 0.5h)
> Fix the handling of collection field types during ORC schema up-conversion in
> compaction
> ----------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1257
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1257
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-compaction
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Issac Buenrostro
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently, on schema change while copying map/list entries from the original
> schema into the evolved schema, all the entries in the collection point to
> the same reference. This is inadvertently caused by re-using the same
> WritableComparable object for all the values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
