[
https://issues.apache.org/jira/browse/GOBBLIN-1278?focusedWorklogId=496231&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-496231
]
ASF GitHub Bot logged work on GOBBLIN-1278:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Oct/20 23:13
Start Date: 06/Oct/20 23:13
Worklog Time Spent: 10m
Work Description: codecov-io commented on pull request #3118:
URL:
https://github.com/apache/incubator-gobblin/pull/3118#issuecomment-704601243
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3118?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(`master@1cf79ef`). [Click here to learn what that
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `63.15%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3118?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3118 +/- ##
=========================================
Coverage ? 41.74%
Complexity ? 8736
=========================================
Files ? 1986
Lines ? 75793
Branches ? 8445
=========================================
Hits ? 31642
Misses ? 41132
Partials ? 3019
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3118?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...ction/action/CompactionHiveRegistrationAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3118/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25IaXZlUmVnaXN0cmF0aW9uQWN0aW9uLmphdmE=)
| `37.50% <33.33%> (ø)` | `4.00 <0.00> (?)` | |
|
[...n/compaction/action/CompactionWatermarkAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3118/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25XYXRlcm1hcmtBY3Rpb24uamF2YQ==)
| `76.66% <76.92%> (ø)` | `11.00 <0.00> (?)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3118?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3118?src=pr&el=footer).
Last update
[1cf79ef...6dc0076](https://codecov.io/gh/apache/incubator-gobblin/pull/3118?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 496231)
Time Spent: 20m (was: 10m)
> Close HiveRegister in completion action usage
> ---------------------------------------------
>
> Key: GOBBLIN-1278
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1278
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zhixiong Chen
> Assignee: Zhixiong Chen
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In a compaction with watermark flow, `CompactionHiveRegistrationAction` and
> `CompactionWatermarkAction` can concurrently alter a table, which may end up
> old table parameters replace new ones. To serialize, the idea is to `close`
> the `HiveRegister` instance, waiting for all hive updates complete, before
> returning.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
