[
https://issues.apache.org/jira/browse/GOBBLIN-1273?focusedWorklogId=497005&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-497005
]
ASF GitHub Bot logged work on GOBBLIN-1273:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Oct/20 23:33
Start Date: 07/Oct/20 23:33
Worklog Time Spent: 10m
Work Description: codecov-io commented on pull request #3113:
URL:
https://github.com/apache/incubator-gobblin/pull/3113#issuecomment-705247118
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3113?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(`master@06b9159`). [Click here to learn what that
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3113?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3113 +/- ##
=========================================
Coverage ? 46.01%
Complexity ? 9579
=========================================
Files ? 1986
Lines ? 75802
Branches ? 8445
=========================================
Hits ? 34882
Misses ? 37638
Partials ? 3282
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3113?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...n/java/org/apache/gobblin/util/PullFileLoader.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3113/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvUHVsbEZpbGVMb2FkZXIuamF2YQ==)
| `73.88% <77.77%> (ø)` | `26.00 <3.00> (?)` | |
|
[...pache/gobblin/util/executors/ForceQueuePolicy.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3113/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZXhlY3V0b3JzL0ZvcmNlUXVldWVQb2xpY3kuamF2YQ==)
| `16.66% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
|
[...bblin/writer/http/SalesForceRestWriterBuilder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3113/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9odHRwL1NhbGVzRm9yY2VSZXN0V3JpdGVyQnVpbGRlci5qYXZh)
| `72.50% <0.00%> (ø)` | `12.00% <0.00%> (?%)` | |
|
[...ion/mapreduce/orc/OrcKeyCompactorOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3113/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL29yYy9PcmNLZXlDb21wYWN0b3JPdXRwdXRGb3JtYXQuamF2YQ==)
| `100.00% <0.00%> (ø)` | `4.00% <0.00%> (?%)` | |
|
[...ice/modules/orchestration/AzkabanClientStatus.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3113/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9zZXJ2aWNlL21vZHVsZXMvb3JjaGVzdHJhdGlvbi9BemthYmFuQ2xpZW50U3RhdHVzLmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
|
[...che/gobblin/util/limiter/NonRefillableLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3113/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob25SZWZpbGxhYmxlTGltaXRlci5qYXZh)
| `75.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
|
[...cies/avro/AvroRecordTimestampLowerBoundPolicy.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3113/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3BvbGljaWVzL2F2cm8vQXZyb1JlY29yZFRpbWVzdGFtcExvd2VyQm91bmRQb2xpY3kuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
|
[...in/java/org/apache/gobblin/metrics/InnerMeter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3113/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Jbm5lck1ldGVyLmphdmE=)
| `100.00% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
|
[...obblin/ingestion/google/webmaster/UrlTrieNode.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3113/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvb2dsZS1pbmdlc3Rpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vaW5nZXN0aW9uL2dvb2dsZS93ZWJtYXN0ZXIvVXJsVHJpZU5vZGUuamF2YQ==)
| `90.62% <0.00%> (ø)` | `10.00% <0.00%> (?%)` | |
|
[...gobblin/runtime/DynamicConfigGeneratorFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3113/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvRHluYW1pY0NvbmZpZ0dlbmVyYXRvckZhY3RvcnkuamF2YQ==)
| `57.14% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| ... and [1977
more](https://codecov.io/gh/apache/incubator-gobblin/pull/3113/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3113?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3113?src=pr&el=footer).
Last update
[06b9159...6a19405](https://codecov.io/gh/apache/incubator-gobblin/pull/3113?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 497005)
Time Spent: 0.5h (was: 20m)
> Pull or Conf file loading failures are not easy to understand
> -------------------------------------------------------------
>
> Key: GOBBLIN-1273
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1273
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Shirshanka Das
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When config files fail to load (specifically hocon files), Gobblin doesn't
> log which file and which line number caused the failure.
>
> e.g. if a .conf file with unquoted : characters is found in a standalone
> server's config directory, the startup aborts with the following message:
>
> _Exception in thread "main" java.lang.IllegalStateException: Expected to be
> healthy after starting_
> _at com.google.common.base.Preconditions.checkState(Preconditions.java:150)_
> _at
> com.google.common.util.concurrent.ServiceManager.awaitHealthy(ServiceManager.java:278)_
> _at
> org.apache.gobblin.runtime.app.ServiceBasedAppLauncher.start(ServiceBasedAppLauncher.java:168)_
> _at
> org.apache.gobblin.scheduler.SchedulerDaemon.main(SchedulerDaemon.java:75)_
> _Exception in thread "JobScheduler STARTING"
> com.typesafe.config.ConfigException$BadPath: Reader: 30: Token not allowed in
> path expression: ':' (you can double-quote this token if you really want it
> here)_
> _at com.typesafe.config.impl.Parser.parsePathExpression(Parser.java:1095)_
> _at com.typesafe.config.impl.Parser.parsePathExpression(Parser.java:1049)_
> _at com.typesafe.config.impl.Parser.access$000(Parser.java:27)_
> _..._
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
