[
https://issues.apache.org/jira/browse/GOBBLIN-1291?focusedWorklogId=501925&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-501925
]
ASF GitHub Bot logged work on GOBBLIN-1291:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Oct/20 19:36
Start Date: 18/Oct/20 19:36
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request #3130:
URL: https://github.com/apache/incubator-gobblin/pull/3130
Certain Gobblin modules such as gobblin-elasticsearch install tars using
scripts during testing. Occassionally these tars are not cleaned up fully by
`./uninstall_test_deps.sh` which causes the file to be picked up by the
:sourceRelease task, causing it to fail.
The patch ignores these tars adding files to the release tar.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 501925)
Remaining Estimate: 0h
Time Spent: 10m
> Test packages are not properly being cleaned up before release
> --------------------------------------------------------------
>
> Key: GOBBLIN-1291
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1291
> Project: Apache Gobblin
> Issue Type: Bug
> Affects Versions: 0.15.0
> Reporter: William Lo
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, after running a clean build, there is a chance that the
> :sourceRelease task fails due to attempting to add improperly deleted jars
> such as elasticsearch and couchbase. Those jars are only being used for
> testing purposes and as such should be ignored when performing sourceRelease
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
