arjun4084346 commented on a change in pull request #3140:
URL: https://github.com/apache/incubator-gobblin/pull/3140#discussion_r512210806
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/policy/CombineRetentionPolicy.java
##########
@@ -110,6 +105,30 @@ public CombineRetentionPolicy(Properties props) throws
IOException {
}
+ private List<RetentionPolicy<T>> findRetentionPolicies(Properties props) {
+ List<String> retentionPolicyClasses;
+ ImmutableList.Builder<RetentionPolicy<T>> builder =
ImmutableList.builder();
+ ClassAliasResolver<?> aliasResolver = new
ClassAliasResolver<>(RetentionPolicy.class);
+
+ if (props.containsKey(COMBINE_RETENTION_POLICIES)) {
+ retentionPolicyClasses =
COMMA_BASED_SPLITTER.splitToList(props.getProperty(COMBINE_RETENTION_POLICIES));
Review comment:
It is there at Line 78
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]