[
https://issues.apache.org/jira/browse/GOBBLIN-1302?focusedWorklogId=504913&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-504913
]
ASF GitHub Bot logged work on GOBBLIN-1302:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/20 20:39
Start Date: 26/Oct/20 20:39
Worklog Time Spent: 10m
Work Description: codecov-io edited a comment on pull request #3140:
URL:
https://github.com/apache/incubator-gobblin/pull/3140#issuecomment-716059650
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3140?src=pr&el=h1)
Report
> Merging
[#3140](https://codecov.io/gh/apache/incubator-gobblin/pull/3140?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/6e9bb2af7e8ee8c482bf94f3c323c5bd76c748ff?el=desc)
will **increase** coverage by `0.01%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3140?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3140 +/- ##
============================================
+ Coverage 46.02% 46.03% +0.01%
- Complexity 9580 9589 +9
============================================
Files 1986 1986
Lines 75795 75819 +24
Branches 8445 8446 +1
============================================
+ Hits 34884 34906 +22
+ Misses 37634 37633 -1
- Partials 3277 3280 +3
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3140?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3140/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `34.71% <0.00%> (-3.31%)` | `13.00 <0.00> (-1.00)` | |
|
[...ent/retention/policy/DeleteAllRetentionPolicy.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3140/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9wb2xpY3kvRGVsZXRlQWxsUmV0ZW50aW9uUG9saWN5LmphdmE=)
| `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
|
[...retention/policy/DeleteNothingRetentionPolicy.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3140/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9wb2xpY3kvRGVsZXRlTm90aGluZ1JldGVudGlvblBvbGljeS5qYXZh)
| `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
|
[...ement/retention/policy/NewestKRetentionPolicy.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3140/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9wb2xpY3kvTmV3ZXN0S1JldGVudGlvblBvbGljeS5qYXZh)
| `92.00% <ø> (ø)` | `9.00 <0.00> (ø)` | |
|
[...ent/retention/policy/PredicateRetentionPolicy.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3140/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9wb2xpY3kvUHJlZGljYXRlUmV0ZW50aW9uUG9saWN5LmphdmE=)
| `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
|
[...ent/retention/policy/TimeBasedRetentionPolicy.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3140/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9wb2xpY3kvVGltZUJhc2VkUmV0ZW50aW9uUG9saWN5LmphdmE=)
| `96.00% <ø> (ø)` | `10.00 <0.00> (ø)` | |
|
[.../java/org/apache/gobblin/util/PropertiesUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3140/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvUHJvcGVydGllc1V0aWxzLmphdmE=)
| `34.14% <75.00%> (+4.41%)` | `8.00 <2.00> (+2.00)` | |
|
[...ement/retention/policy/CombineRetentionPolicy.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3140/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9wb2xpY3kvQ29tYmluZVJldGVudGlvblBvbGljeS5qYXZh)
| `75.38% <86.66%> (+2.05%)` | `17.00 <4.00> (+2.00)` | |
|
[...a/org/apache/gobblin/service/FlowConfigClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3140/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnQ2xpZW50LmphdmE=)
| `71.66% <0.00%> (-2.48%)` | `8.00% <0.00%> (ø%)` | |
| ... and [17
more](https://codecov.io/gh/apache/incubator-gobblin/pull/3140/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3140?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3140?src=pr&el=footer).
Last update
[6e9bb2a...5127729](https://codecov.io/gh/apache/incubator-gobblin/pull/3140?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 504913)
Time Spent: 40m (was: 0.5h)
> make CombineRetentionPolicy easily configurable
> -----------------------------------------------
>
> Key: GOBBLIN-1302
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1302
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> currently these configs need to have config prefixed by
> `combine.retention.policy.class.`
> and each policy need a separate config. we should make one config defining
> all the individual retention policies
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
