[
https://issues.apache.org/jira/browse/GOBBLIN-1304?focusedWorklogId=506665&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-506665
]
ASF GitHub Bot logged work on GOBBLIN-1304:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Nov/20 13:32
Start Date: 03/Nov/20 13:32
Worklog Time Spent: 10m
Work Description: Will-Lo commented on a change in pull request #3142:
URL: https://github.com/apache/incubator-gobblin/pull/3142#discussion_r516156242
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/GroupOwnershipService.java
##########
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.service;
+
+import java.util.List;
+
+
+public abstract class GroupOwnershipService {
+ public static String USER_TYPE = "USER_PRINCIPAL";
+
+ abstract boolean isMemberOfGroup(List<ServiceRequester> serviceRequesters,
String group);
Review comment:
By default it should be protected but I'll explicitly define it as such
too
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/GroupOwnershipService.java
##########
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.service;
+
+import java.util.List;
+
+
+public abstract class GroupOwnershipService {
+ public static String USER_TYPE = "USER_PRINCIPAL";
+
+ abstract boolean isMemberOfGroup(List<ServiceRequester> serviceRequesters,
String group);
Review comment:
Since the class is public abstract by default it should be protected but
I'll explicitly define it as such too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 506665)
Time Spent: 40m (was: 0.5h)
> Group Ownership Service
> -----------------------
>
> Key: GOBBLIN-1304
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1304
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add an option for users to specify owning_groups, so that other requesters
> within the same group can modify and delete flows.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
