[
https://issues.apache.org/jira/browse/GOBBLIN-1323?focusedWorklogId=515771&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515771
]
ASF GitHub Bot logged work on GOBBLIN-1323:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/20 21:39
Start Date: 23/Nov/20 21:39
Worklog Time Spent: 10m
Work Description: wenqinduke opened a new pull request #3156:
URL: https://github.com/apache/incubator-gobblin/pull/3156
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title.
https://issues.apache.org/jira/browse/GOBBLIN-1323
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Wrap Utils.getColumnListFromQuery(inputQuery) so that child class can
override it to support customized query.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
I do not include a test because there is no code content change, only
structure changes.
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 515771)
Remaining Estimate: 0h
Time Spent: 10m
> make columnListInQuery in RestApiExtractor overridable in child class for
> Dynamics Extractor
> --------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1323
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1323
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: Wenqin Wang
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Recently we've discovered that in our Dynamics ingestion pipeline, we would
> not remove invalid fields in our query before pulling data for dynamics
> entities, and therefore gobblin ingestion would fail due to field not found
> error. This feature is implemented for Salesforce in RestApiExtrator.java,
> and the logic is specifically tailored for Salesforce. Therefore i'm
> proposing some changes and hope to get Gobblin dev's guidance and reviews.
> For Dynamics, to enable this feature, here is the solution that I think works
> the best:
> since the query looks different from Salesforce query, we need to change the
> way we extract fields from client-specified-query. I will make a protected
> method in RestApiExtractor.java to wrap this Utils.getColumnListFromQuery,
> and override it in DynamicsExtractor.java (the child class) to write specific
> logic for dynamics use case. After that, we can override the buildDataQuery
> method in DynamicsExtractor.java ourselves to replace user-specified-query
> with validated fields. This way it would not affect other extractors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
