jhsenjaliya commented on a change in pull request #3157:
URL: https://github.com/apache/incubator-gobblin/pull/3157#discussion_r533083318
##########
File path:
gobblin-utility/src/main/java/org/apache/gobblin/util/hadoop/TokenUtils.java
##########
@@ -132,6 +134,35 @@ public Void run() throws Exception {
return ugi;
}
+ public static void getHadoopFSTokens(final State state, Optional<File>
tokenFile, final Credentials cred, final String renewer)
Review comment:
You can. But this function should take renewer regardless. The user of
this function can implement to take renewer from config as override but we
found that its better to use the process owner as default renewer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
