[
https://issues.apache.org/jira/browse/GOBBLIN-1334?focusedWorklogId=522379&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-522379
]
ASF GitHub Bot logged work on GOBBLIN-1334:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Dec/20 18:36
Start Date: 09/Dec/20 18:36
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request #3170:
URL: https://github.com/apache/incubator-gobblin/pull/3170
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1334
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
Extends the Watermark CLI tool to have delete capabilities based on job ID.
Also performs some refactoring to clean up and test the CLI tool.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
- adds tests for `StateStoreWatermarkStorage`
- adds tests for `StateStoreBasedWatermarkStorageCli`
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 522379)
Remaining Estimate: 0h
Time Spent: 10m
> Extend watermark state store CLI tool to handle watermark deletes
> -----------------------------------------------------------------
>
> Key: GOBBLIN-1334
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1334
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: William Lo
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Watermark deletion is a manual process.
> Extend the command line tool to handle watermark deletes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
