[
https://issues.apache.org/jira/browse/GOBBLIN-867?focusedWorklogId=528128&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-528128
]
ASF GitHub Bot logged work on GOBBLIN-867:
------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Dec/20 13:12
Start Date: 24/Dec/20 13:12
Worklog Time Spent: 10m
Work Description: codecov-io commented on pull request #3183:
URL:
https://github.com/apache/incubator-gobblin/pull/3183#issuecomment-750879478
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3183?src=pr&el=h1)
Report
> Merging
[#3183](https://codecov.io/gh/apache/incubator-gobblin/pull/3183?src=pr&el=desc)
(52cfa16) into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/38765e7dc0010637c58f8e2072799fd2a9adbd9f?el=desc)
(38765e7) will **decrease** coverage by `4.23%`.
> The diff coverage is `26.08%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3183?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3183 +/- ##
============================================
- Coverage 46.20% 41.96% -4.24%
+ Complexity 9759 8904 -855
============================================
Files 2014 2014
Lines 77099 77098 -1
Branches 8559 8555 -4
============================================
- Hits 35625 32356 -3269
- Misses 38170 41697 +3527
+ Partials 3304 3045 -259
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3183?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...blin/cluster/ScheduledJobConfigurationManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3183/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2NoZWR1bGVkSm9iQ29uZmlndXJhdGlvbk1hbmFnZXIuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...blin/cluster/StreamingJobConfigurationManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3183/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU3RyZWFtaW5nSm9iQ29uZmlndXJhdGlvbk1hbmFnZXIuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...ache/gobblin/compaction/mapreduce/MRCompactor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3183/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL01SQ29tcGFjdG9yLmphdmE=)
| `7.04% <0.00%> (ø)` | `9.00 <0.00> (ø)` | |
|
[...lin/compaction/mapreduce/MRCompactorJobRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3183/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL01SQ29tcGFjdG9ySm9iUnVubmVyLmphdmE=)
| `0.00% <0.00%> (-17.08%)` | `0.00 <0.00> (-2.00)` | |
|
[...in/compaction/verify/DataCompletenessVerifier.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3183/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vdmVyaWZ5L0RhdGFDb21wbGV0ZW5lc3NWZXJpZmllci5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...nstrumented/writer/InstrumentedDataWriterBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3183/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vaW5zdHJ1bWVudGVkL3dyaXRlci9JbnN0cnVtZW50ZWREYXRhV3JpdGVyQmFzZS5qYXZh)
| `46.15% <0.00%> (ø)` | `14.00 <0.00> (ø)` | |
|
[.../org/apache/gobblin/writer/AsyncWriterManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3183/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL0FzeW5jV3JpdGVyTWFuYWdlci5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...e/gobblin/publisher/HiveRegistrationPublisher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3183/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3B1Ymxpc2hlci9IaXZlUmVnaXN0cmF0aW9uUHVibGlzaGVyLmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...apache/gobblin/writer/http/AbstractHttpWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3183/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9odHRwL0Fic3RyYWN0SHR0cFdyaXRlci5qYXZh)
| `0.00% <0.00%> (-56.07%)` | `0.00 <0.00> (-12.00)` | |
|
[...blin/data/management/retention/DatasetCleaner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3183/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi9EYXRhc2V0Q2xlYW5lci5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [195
more](https://codecov.io/gh/apache/incubator-gobblin/pull/3183/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3183?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3183?src=pr&el=footer).
Last update
[38765e7...52cfa16](https://codecov.io/gh/apache/incubator-gobblin/pull/3183?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 528128)
Time Spent: 20m (was: 10m)
> use logger from class instead of passing it around
> --------------------------------------------------
>
> Key: GOBBLIN-867
> URL: https://issues.apache.org/jira/browse/GOBBLIN-867
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jay Sen
> Assignee: Ivan Gavlik
> Priority: Trivial
> Time Spent: 20m
> Remaining Estimate: 0h
>
> in some classes, mainly static methods, expects the logger, so user of the
> methods has to pass the logger, these static methods are utils anyway, should
> just have their own logger.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
