[
https://issues.apache.org/jira/browse/GOBBLIN-1355?focusedWorklogId=533647&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-533647
]
ASF GitHub Bot logged work on GOBBLIN-1355:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jan/21 04:05
Start Date: 10/Jan/21 04:05
Worklog Time Spent: 10m
Work Description: codecov-io commented on pull request #3195:
URL:
https://github.com/apache/incubator-gobblin/pull/3195#issuecomment-757073892
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3195?src=pr&el=h1)
Report
> Merging
[#3195](https://codecov.io/gh/apache/incubator-gobblin/pull/3195?src=pr&el=desc)
(a9c5a4b) into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/1b31c907a5b46917b0d3319be49b3a88764944a2?el=desc)
(1b31c90) will **increase** coverage by `0.00%`.
> The diff coverage is `33.33%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3195?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3195 +/- ##
========================================
Coverage 9.10% 9.11%
- Complexity 1726 1727 +1
========================================
Files 2017 2017
Lines 77221 77215 -6
Branches 8568 8569 +1
========================================
+ Hits 7033 7036 +3
+ Misses 69500 69491 -9
Partials 688 688
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3195?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3195/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh)
| `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
|
[...src/main/java/org/apache/gobblin/runtime/Task.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3195/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFzay5qYXZh)
| `51.01% <33.33%> (-0.01%)` | `57.00 <0.00> (ø)` | |
|
[.../gobblin/cluster/HelixRetriggeringJobCallable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3195/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhSZXRyaWdnZXJpbmdKb2JDYWxsYWJsZS5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3195/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `62.17% <0.00%> (+0.64%)` | `33.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3195?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3195?src=pr&el=footer).
Last update
[1b31c90...aece75f](https://codecov.io/gh/apache/incubator-gobblin/pull/3195?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 533647)
Time Spent: 50m (was: 40m)
> Make task interruption optional on Gobblin task cancellation
> ------------------------------------------------------------
>
> Key: GOBBLIN-1355
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1355
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Affects Versions: 0.16.0
> Reporter: Sudarshan Vasudevan
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently, the thread running a Gobblin task is interrupted when a task
> cancellation is invoked. When such a task is managing a Kafka consumer for
> instance, the interrupt leaves the consumer instance in a corrupt state,
> particularly if the consumer is in the middle of a poll() when the interrupt
> occurs. This in turn prevents the subsequent clean up of the consumer
> instance resulting in a potential resource leak.
> With this change, we provide the option to avoid interrupting the thread in
> aforementioned scenarios and let the poll() return before the thread is
> shutdown.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
