[ 
https://issues.apache.org/jira/browse/GOBBLIN-1359?focusedWorklogId=542427&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542427
 ]

ASF GitHub Bot logged work on GOBBLIN-1359:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Jan/21 21:36
            Start Date: 26/Jan/21 21:36
    Worklog Time Spent: 10m 
      Work Description: ZihanLi58 opened a new pull request #3214:
URL: https://github.com/apache/incubator-gobblin/pull/3214


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1359
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if 
applicable):
   
   After the first change 
https://github.com/apache/incubator-gobblin/pull/3200, we still see the job 
hang if onNext throw error after a long processing time (i.e. 5 mins). And 
after investigating, we see the ConnectableFlowable.connect() which is supposed 
to return immediately does not return even the flow is finished and canceled. 
So the solution will be make the call in another thread, and let the sequence 
code get executed which is to periodically check whether the job finished.
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   Run Azkaban job to simulate the slow write, and make sure the exception can 
set the fork state to FAIL and cause task to fail and retry
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 542427)
    Time Spent: 1h 40m  (was: 1.5h)

> Fix the error that IOException thrown by writer be swallowed by Reactivex 
> --------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1359
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1359
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: Zihan Li
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> we have a bug in Reactivex code which swallows the exception and leaves the 
> task hanging



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to