ZihanLi58 commented on a change in pull request #3207:
URL: https://github.com/apache/incubator-gobblin/pull/3207#discussion_r564882352
##########
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnConfigurationKeys.java
##########
@@ -124,4 +126,5 @@
public static final String GOBBLIN_YARN_AZKABAN_CLASS_LOG_LEVELS =
GOBBLIN_YARN_PREFIX + "azkaban.class.logLevels";
//Container classpaths properties
public static final String GOBBLIN_YARN_ADDITIONAL_CLASSPATHS =
GOBBLIN_YARN_PREFIX + "additional.classpaths";
+ public static final String GOBBLIN_YARN_CLASSPATHS = GOBBLIN_YARN_PREFIX +
"classpaths";
Review comment:
Additional path is to add new class path on the default one which is set
the the yarn config. And in our case, we need to overwrite the default config
to a different class path, so I just add a new config and keep the old one for
backward compatibility and support more flexible use case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
