[
https://issues.apache.org/jira/browse/GOBBLIN-1379?focusedWorklogId=544708&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-544708
]
ASF GitHub Bot logged work on GOBBLIN-1379:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jan/21 08:50
Start Date: 30/Jan/21 08:50
Worklog Time Spent: 10m
Work Description: codecov-io commented on pull request #3219:
URL:
https://github.com/apache/incubator-gobblin/pull/3219#issuecomment-770179493
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3219?src=pr&el=h1)
Report
> Merging
[#3219](https://codecov.io/gh/apache/incubator-gobblin/pull/3219?src=pr&el=desc)
(a154b0c) into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/5ecf9a175d745e1b2b46bea5de4ba89512866e5e?el=desc)
(5ecf9a1) will **decrease** coverage by `37.09%`.
> The diff coverage is `46.15%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3219?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3219 +/- ##
============================================
- Coverage 46.26% 9.17% -37.10%
+ Complexity 9796 1737 -8059
============================================
Files 2019 2019
Lines 77506 77555 +49
Branches 8607 8612 +5
============================================
- Hits 35861 7112 -28749
- Misses 38310 69748 +31438
+ Partials 3335 695 -2640
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3219?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...nt/copy/writer/FileAwareInputStreamDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvd3JpdGVyL0ZpbGVBd2FyZUlucHV0U3RyZWFtRGF0YVdyaXRlci5qYXZh)
| `0.00% <0.00%> (-71.65%)` | `0.00 <0.00> (-38.00)` | |
|
[...in/java/org/apache/gobblin/writer/RetryWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9SZXRyeVdyaXRlci5qYXZh)
| `69.69% <100.00%> (+1.95%)` | `9.00 <0.00> (ø)` | |
|
[...c/main/java/org/apache/gobblin/util/FileUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZVV0aWxzLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
|
[...n/java/org/apache/gobblin/fork/CopyableSchema.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZvcmsvQ29weWFibGVTY2hlbWEuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
|
[...java/org/apache/gobblin/stream/ControlMessage.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc3RyZWFtL0NvbnRyb2xNZXNzYWdlLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...va/org/apache/gobblin/dataset/DatasetResolver.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC9EYXRhc2V0UmVzb2x2ZXIuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
|
[...va/org/apache/gobblin/converter/EmptyIterable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9FbXB0eUl0ZXJhYmxlLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...org/apache/gobblin/ack/BasicAckableForTesting.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYWNrL0Jhc2ljQWNrYWJsZUZvclRlc3RpbmcuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
|
[...n/java/org/apache/gobblin/salesforce/SfConfig.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2ZDb25maWcuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[.../org/apache/gobblin/yarn/HelixMessageSubTypes.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vSGVsaXhNZXNzYWdlU3ViVHlwZXMuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1067
more](https://codecov.io/gh/apache/incubator-gobblin/pull/3219/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3219?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3219?src=pr&el=footer).
Last update
[5ecf9a1...a154b0c](https://codecov.io/gh/apache/incubator-gobblin/pull/3219?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 544708)
Time Spent: 20m (was: 10m)
> Distcp hides real exception when retry happen
> ---------------------------------------------
>
> Key: GOBBLIN-1379
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1379
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: Alex Prokofiev
> Assignee: Abhishek Tiwari
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When folder creation fails in FileAwareInputStreamDataWriter with permission
> error , operation is retried. However, the original permission error is not
> logged or shown anywhere. Instead users see a misleading error about
> incorrect writer state.
> {code:java}
> 2021-01-14 20:04:21,173 ERROR [main] org.apache.gobblin.runtime.fork.Fork-0:
> Fork 0 of task task_HiveDistcpForDatabasesTier0_1610654490216_2004 failed to
> process data records. Set throwable in holder
> org.apache.gobblin.runtime.ForkThrowableHolder@567cfbdd
> java.io.IOException: com.github.rholder.retry.RetryException: Retrying failed
> to complete successfully after 5 attempts.
> at org.apache.gobblin.writer.RetryWriter.callWithRetry(RetryWriter.java:144)
> at org.apache.gobblin.writer.RetryWriter.writeEnvelope(RetryWriter.java:124)
> at org.apache.gobblin.runtime.fork.Fork.processRecord(Fork.java:520)
> at
> org.apache.gobblin.runtime.fork.AsynchronousFork.processRecord(AsynchronousFork.java:103)
> at
> org.apache.gobblin.runtime.fork.AsynchronousFork.processRecords(AsynchronousFork.java:86)
> at org.apache.gobblin.runtime.fork.Fork.run(Fork.java:250)
> at
> org.apache.gobblin.util.executors.MDCPropagatingRunnable.run(MDCPropagatingRunnable.java:39)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: com.github.rholder.retry.RetryException: Retrying failed to
> complete successfully after 5 attempts.
> at com.github.rholder.retry.Retryer.call(Retryer.java:174)
> at com.github.rholder.retry.Retryer$RetryerCallable.call(Retryer.java:318)
> at org.apache.gobblin.writer.RetryWriter.callWithRetry(RetryWriter.java:142)
> ... 11 more
> Caused by: java.io.IOException:
> org.apache.gobblin.data.management.copy.writer.FileAwareInputStreamDataWriter
> can only process one file.
> at
> org.apache.gobblin.data.management.copy.writer.FileAwareInputStreamDataWriter.writeImpl(FileAwareInputStreamDataWriter.java:199)
> at
> org.apache.gobblin.data.management.copy.writer.FileAwareInputStreamDataWriter.writeImpl(FileAwareInputStreamDataWriter.java:83)
> at
> org.apache.gobblin.instrumented.writer.InstrumentedDataWriterBase.write(InstrumentedDataWriterBase.java:158)
> at
> org.apache.gobblin.instrumented.writer.InstrumentedDataWriter.write(InstrumentedDataWriter.java:38)
> at org.apache.gobblin.writer.DataWriter.writeEnvelope(DataWriter.java:106)
> at
> org.apache.gobblin.writer.CloseOnFlushWriterWrapper.writeEnvelope(CloseOnFlushWriterWrapper.java:97)
> at
> org.apache.gobblin.instrumented.writer.InstrumentedDataWriterDecorator.writeEnvelope(InstrumentedDataWriterDecorator.java:76)
> at
> org.apache.gobblin.writer.PartitionedDataWriter.writeEnvelope(PartitionedDataWriter.java:239)
> at org.apache.gobblin.writer.RetryWriter$2.call(RetryWriter.java:119)
> at org.apache.gobblin.writer.RetryWriter$2.call(RetryWriter.java:116)
> at
> com.github.rholder.retry.AttemptTimeLimiters$NoAttemptTimeLimit.call(AttemptTimeLimiters.java:78)
> at com.github.rholder.retry.Retryer.call(Retryer.java:160)
> ... 13 more
> 2021-01-14 20:04:21,173 INFO [main] org.apache.gobblin.runtime.Task: Task
> shutdown: Fork future reaped in 15358 millis
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
