[
https://issues.apache.org/jira/browse/GOBBLIN-1396?focusedWorklogId=560103&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560103
]
ASF GitHub Bot logged work on GOBBLIN-1396:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/21 19:34
Start Date: 02/Mar/21 19:34
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on a change in pull request #3234:
URL: https://github.com/apache/gobblin/pull/3234#discussion_r585850403
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/HiveRegister.java
##########
@@ -322,7 +322,7 @@ public void addOrAlterPartition(HiveTable table,
HivePartition partition)
}
}
- protected boolean needToUpdateTable(HiveTable existingTable, HiveTable
newTable) {
+ public boolean needToUpdateTable(HiveTable existingTable, HiveTable
newTable) {
Review comment:
I move it under gobblin-hive-registration module but a new package
writer for better management. So it still needs to be changed to public. Let me
know if you have any concerns
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 560103)
Time Spent: 40m (was: 0.5h)
> Enable HiveWriter to consume gmce and register into hive MetadataStore
> ----------------------------------------------------------------------
>
> Key: GOBBLIN-1396
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1396
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add hiveWriter as one subtype of metadataWriter, so that it can consume gmce
> and register into hive metaStore. The writer should avoid trying to register
> the same HiveSpec several times also it should be able to handle the schema
> evolution.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
