[
https://issues.apache.org/jira/browse/GOBBLIN-1413?focusedWorklogId=573859&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-573859
]
ASF GitHub Bot logged work on GOBBLIN-1413:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Mar/21 03:14
Start Date: 30/Mar/21 03:14
Worklog Time Spent: 10m
Work Description: codecov-io commented on pull request #3252:
URL: https://github.com/apache/gobblin/pull/3252#issuecomment-809872859
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3252?src=pr&el=h1)
Report
> Merging
[#3252](https://codecov.io/gh/apache/gobblin/pull/3252?src=pr&el=desc)
(5c037a5) into
[master](https://codecov.io/gh/apache/gobblin/commit/d9ae5353c74fdcd385835fca9b586b3fdb90971b?el=desc)
(d9ae535) will **decrease** coverage by `37.41%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/gobblin/pull/3252?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3252 +/- ##
============================================
- Coverage 46.42% 9.00% -37.42%
+ Complexity 9974 1738 -8236
============================================
Files 2034 2034
Lines 79042 79078 +36
Branches 8809 8815 +6
============================================
- Hits 36692 7121 -29571
- Misses 38938 71259 +32321
+ Partials 3412 698 -2714
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3252?src=pr&el=tree) |
Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...org/apache/gobblin/iceberg/GobblinMCEProducer.java](https://codecov.io/gh/apache/gobblin/pull/3252/diff?src=pr&el=tree#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvR29iYmxpbk1DRVByb2R1Y2VyLmphdmE=)
| `0.00% <0.00%> (-48.49%)` | `0.00 <0.00> (-12.00)` | |
|
[...gobblin/iceberg/publisher/GobblinMCEPublisher.java](https://codecov.io/gh/apache/gobblin/pull/3252/diff?src=pr&el=tree#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvcHVibGlzaGVyL0dvYmJsaW5NQ0VQdWJsaXNoZXIuamF2YQ==)
| `0.00% <0.00%> (-63.34%)` | `0.00 <0.00> (-12.00)` | |
|
[.../gobblin/iceberg/writer/IcebergMetadataWriter.java](https://codecov.io/gh/apache/gobblin/pull/3252/diff?src=pr&el=tree#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvd3JpdGVyL0ljZWJlcmdNZXRhZGF0YVdyaXRlci5qYXZh)
| `0.00% <0.00%> (-67.59%)` | `0.00 <0.00> (-51.00)` | |
|
[...c/main/java/org/apache/gobblin/util/FileUtils.java](https://codecov.io/gh/apache/gobblin/pull/3252/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZVV0aWxzLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
|
[...n/java/org/apache/gobblin/fork/CopyableSchema.java](https://codecov.io/gh/apache/gobblin/pull/3252/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZvcmsvQ29weWFibGVTY2hlbWEuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
|
[...java/org/apache/gobblin/stream/ControlMessage.java](https://codecov.io/gh/apache/gobblin/pull/3252/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc3RyZWFtL0NvbnRyb2xNZXNzYWdlLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...va/org/apache/gobblin/dataset/DatasetResolver.java](https://codecov.io/gh/apache/gobblin/pull/3252/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC9EYXRhc2V0UmVzb2x2ZXIuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
|
[...va/org/apache/gobblin/converter/EmptyIterable.java](https://codecov.io/gh/apache/gobblin/pull/3252/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9FbXB0eUl0ZXJhYmxlLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...org/apache/gobblin/ack/BasicAckableForTesting.java](https://codecov.io/gh/apache/gobblin/pull/3252/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYWNrL0Jhc2ljQWNrYWJsZUZvclRlc3RpbmcuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
|
[...n/java/org/apache/gobblin/salesforce/SfConfig.java](https://codecov.io/gh/apache/gobblin/pull/3252/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2ZDb25maWcuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1078
more](https://codecov.io/gh/apache/gobblin/pull/3252/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3252?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3252?src=pr&el=footer).
Last update
[d9ae535...5c037a5](https://codecov.io/gh/apache/gobblin/pull/3252?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 573859)
Time Spent: 40m (was: 0.5h)
> Emit GMCE as long as watermark moved
> ------------------------------------
>
> Key: GOBBLIN-1413
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1413
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Hanghang Liu
> Priority: Critical
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Emit GMCE(Gobblin Metadata Change Event) as long as watermark moved on
> streaming pipeline.
> Currently the GMCE won't be triggered within streaming pipeline if no new
> file being generated. This causes problem if watermarks moved, while no file
> being generated(for example, data been filtered out by quality checker), GMCE
> will be missed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
