[
https://issues.apache.org/jira/browse/GOBBLIN-1453?focusedWorklogId=603349&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-603349
]
ASF GitHub Bot logged work on GOBBLIN-1453:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/May/21 00:31
Start Date: 28/May/21 00:31
Worklog Time Spent: 10m
Work Description: jack-moseley commented on a change in pull request
#3291:
URL: https://github.com/apache/gobblin/pull/3291#discussion_r641073241
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/MultiHopFlowCompiler.java
##########
@@ -201,13 +202,19 @@ public void awaitHealthy() throws InterruptedException {
for (FlowSpec datasetFlowSpec : flowSpecs) {
for (DataNode destNode : destNodes) {
long authStartTime = System.nanoTime();
- boolean authorized =
this.dataMovementAuthorizer.isMovementAuthorized(flowSpec, sourceNode,
destNode);
- Instrumented.updateTimer(dataAuthorizationTimer, System.nanoTime() -
authStartTime, TimeUnit.NANOSECONDS);
- if (!authorized) {
- String message = String.format("Data movement is not authorized
for flow: %s, source: %s, destination: %s",
- flowSpec.getUri().toString(), source, destination);
- log.error(message);
- datasetFlowSpec.getCompilationErrors().add(message);
+ try {
Review comment:
So for the NPE we experienced previously, it happened inside this block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 603349)
Time Spent: 50m (was: 40m)
> Improve error reporting on flow configs that fail to compile
> ------------------------------------------------------------
>
> Key: GOBBLIN-1453
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1453
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Affects Versions: 0.16.0
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Flow configurations that fail to compile can still be saved in some scenarios.
> Additionally, when they are rejected by the server, there should be a more
> detailed explanation as to why instead of just returning a 400.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
