sv2000 commented on a change in pull request #3289:
URL: https://github.com/apache/gobblin/pull/3289#discussion_r643401645
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/fork/Fork.java
##########
@@ -265,11 +268,15 @@ public void run() {
compareAndSetForkState(ForkState.RUNNING, ForkState.SUCCEEDED);
} catch (Throwable t) {
+ Throwable rootCauseException =
Review comment:
It looks like we are leaking information into the Fork class, making it
aware of exception types such as ForkException and RetryException. Further, the
RetryException is only thrown if a retriable writer is enabled.
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/fork/Fork.java
##########
@@ -265,11 +268,15 @@ public void run() {
compareAndSetForkState(ForkState.RUNNING, ForkState.SUCCEEDED);
} catch (Throwable t) {
+ Throwable rootCauseException =
Review comment:
The other concern I have is if Fork is the right layer at which we
should be unwrapping exceptions. Why not do this inside the Task class?
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/fork/Fork.java
##########
@@ -265,11 +268,15 @@ public void run() {
compareAndSetForkState(ForkState.RUNNING, ForkState.SUCCEEDED);
} catch (Throwable t) {
+ Throwable rootCauseException =
Review comment:
Finally, we may want to preserve the wrapped exceptions as it shows the
sequence in which the exceptions are propagated up, which is useful for
debugging. The "likely" root cause exception can be logged in addition to the
wrapped exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
