[ 
https://issues.apache.org/jira/browse/GOBBLIN-1458?focusedWorklogId=607384&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607384
 ]

ASF GitHub Bot logged work on GOBBLIN-1458:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Jun/21 00:05
            Start Date: 05/Jun/21 00:05
    Worklog Time Spent: 10m 
      Work Description: umustafi commented on a change in pull request #3297:
URL: https://github.com/apache/gobblin/pull/3297#discussion_r645910325



##########
File path: 
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/test/java/org/apache/gobblin/service/FlowConfigV2Test.java
##########
@@ -160,6 +160,8 @@ public void testCheckFlowExecutionId() throws Exception {
   @Test
   public void testPartialUpdate() throws Exception {
     FlowId flowId = new 
FlowId().setFlowGroup(TEST_GROUP_NAME).setFlowName(TEST_FLOW_NAME_3);
+    ServiceRequester testRequester = new ServiceRequester("testName", 
"USER_PRINCIPAL", "testFrom");

Review comment:
       nitpick but do we want to add these as constants if they are reused? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 607384)
    Time Spent: 1h 20m  (was: 1h 10m)

> Add endpoint to trigger a flow in GaaS
> --------------------------------------
>
>                 Key: GOBBLIN-1458
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1458
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Jack Moseley
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to