[ 
https://issues.apache.org/jira/browse/GOBBLIN-1398?focusedWorklogId=607545&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607545
 ]

ASF GitHub Bot logged work on GOBBLIN-1398:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Jun/21 23:53
            Start Date: 06/Jun/21 23:53
    Worklog Time Spent: 10m 
      Work Description: jhsenjaliya commented on a change in pull request #3236:
URL: https://github.com/apache/gobblin/pull/3236#discussion_r646205346



##########
File path: 
gobblin-utility/src/main/java/org/apache/gobblin/util/ConfigUtils.java
##########
@@ -569,4 +608,124 @@ public static Config resolveEncrypted(Config config, 
Optional<String> encConfigP
     }
     return ConfigFactory.parseMap(tmpMap).withFallback(config);
   }
+
+  /**
+   *
+   * @param config
+   * @return ConfigObject ( config in tree ) of the {@link 
ConfigUtils#GOBBLIN_SYNC_SYSTEMS_KEY}
+   */
+  public static ConfigObject getAllSystemConfig(Config config) {
+    return (config.hasPath(GOBBLIN_SYNC_SYSTEMS_KEY) ? 
config.getObject(GOBBLIN_SYNC_SYSTEMS_KEY) : getInstance().root() );
+  }
+
+  /**
+   *
+   * @param config at path: {@link ConfigUtils#GOBBLIN_SYNC_SYSTEMS_KEY}
+   * @return map of system name to that system's config tree for all the 
systems that has security enabled
+   */
+  public static Map<String, ConfigObject> getAllSecureSystems(Config config) {

Review comment:
       I am taking `configUtils` as a `GobblinConfigUtils` which should have 
config utility functions with gobblin's context. but sure it can be separated 
out.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 607545)
    Time Spent: 1h 20m  (was: 1h 10m)

> Gobblin kerberos token management for multiple remote hive metastores
> ---------------------------------------------------------------------
>
>                 Key: GOBBLIN-1398
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1398
>             Project: Apache Gobblin
>          Issue Type: Improvement
>    Affects Versions: 0.15.0
>            Reporter: Jay Sen
>            Priority: Major
>             Fix For: 0.16.0
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> GOBBLIN-1308 takes care of ability to connect to remote and secure hive 
> metastore, but it still requires the management of hive-site to be provided 
> to be container local file. 
> When it comes to multiple hive clusters this manual management approach would 
> not work, and requires special feature of providing system specific 
> hive-site.xml without namespace collision.
>  
> This ticket aims to do following things
> 1) define a way to provide remote system configuration ( keep giving flat 
> config is more cumbersome )
> 2) based on system config and feature flag, copy config files to container 
> local path automatically.
> 3) when creating metastoreClient, pick up the right config for the requested 
> system ( identified by the metastore URI )
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to