[
https://issues.apache.org/jira/browse/GOBBLIN-1466?focusedWorklogId=609404&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-609404
]
ASF GitHub Bot logged work on GOBBLIN-1466:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/21 21:52
Start Date: 09/Jun/21 21:52
Worklog Time Spent: 10m
Work Description: jack-moseley opened a new pull request #3306:
URL: https://github.com/apache/gobblin/pull/3306
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1466
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
Each of the `DagManagerThread`s had its own meter (but with the same names)
previously, which causing confusing results when reading them, instead there
should only be meters shared across the threads.
- For service level meter, created one meter in the `DagManager` and passed
it to each thread instead
- For group level meters, created a static map keyed by group name to be
shared by all threads
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Tested locally by printing meter values in each thread
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 609404)
Remaining Estimate: 0h
Time Spent: 10m
> Make meters shared between DagManagerThreads
> --------------------------------------------
>
> Key: GOBBLIN-1466
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1466
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
