aplex commented on a change in pull request #3307:
URL: https://github.com/apache/gobblin/pull/3307#discussion_r649409189
##########
File path: .github/workflows/build_and_test.yaml
##########
@@ -49,6 +49,9 @@ jobs:
# Only rebuild cache if build.gradle is changed
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
restore-keys: ${{ runner.os }}-gradle
+ - name: Verify Dependencies
+ run: |
+ eval ./gradlew assemble
Review comment:
"gradle build" already includes "gradle assemble" -
https://stackoverflow.com/questions/44185165/what-are-the-differences-between-gradle-assemble-and-gradle-build-tasks
So, is this PR about providing feedback faster than "gradle build" command,
or is it more about trying to catch problems that "gradle build" would not
catch?
If it's about providing faster feedback compared to "Build repository", then
do you see a significant performance improvement locally in "gradle clean
assemble" vs "gradle clean build -x ...." ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
