aplex commented on a change in pull request #3298: URL: https://github.com/apache/gobblin/pull/3298#discussion_r651945730
########## File path: gobblin-metastore/src/main/java/org/apache/gobblin/MysqlDagStore.java ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin; + +import java.io.IOException; + +import javax.sql.DataSource; +import lombok.extern.slf4j.Slf4j; + +import org.apache.gobblin.configuration.State; +import org.apache.gobblin.metastore.MysqlStateStore; +import org.apache.gobblin.service.ServiceConfigKeys; + + +@Slf4j +/** + * An implementation of {@link MysqlStateStore} backed by MySQL to store Dag. + * + * @param <T> state object type + **/ +public class MysqlDagStore<T extends State> extends MysqlStateStore<T> { Review comment: So is this length problem only present for dag store? I would expect that if the flow name is part of the key, it will affect other state stores as well. I see that we have at least a "job_status" state store in shared Gobblin service. And if the new state store is created, it will also hit this problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
