[
https://issues.apache.org/jira/browse/GOBBLIN-1473?focusedWorklogId=611625&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611625
]
ASF GitHub Bot logged work on GOBBLIN-1473:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/21 21:55
Start Date: 15/Jun/21 21:55
Worklog Time Spent: 10m
Work Description: jack-moseley commented on a change in pull request
#3312:
URL: https://github.com/apache/gobblin/pull/3312#discussion_r652180811
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java
##########
@@ -165,8 +165,9 @@ public void run() {
} else {
// Since we are going to change status to isActive=false, unschedule all
flows
for (Spec spec : this.scheduledFlowSpecs.values()) {
- onDeleteSpec(spec.getUri(), spec.getVersion());
+ onDeleteSpec(spec.getUri(), spec.getVersion(), new Properties(),
false);
Review comment:
Yeah that's true, that is much simpler. I was thinking that it may be
expensive to clone all the specs, but we actually only need to clone the list,
and it is okay if they are referencing the same Spec objects since we are not
modifying those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 611625)
Time Spent: 0.5h (was: 20m)
> Fix ConcurrentModificationException when handling leadership change
> -------------------------------------------------------------------
>
> Key: GOBBLIN-1473
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1473
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
