umustafi commented on a change in pull request #3314:
URL: https://github.com/apache/gobblin/pull/3314#discussion_r657483578



##########
File path: 
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java
##########
@@ -217,6 +218,32 @@ private static void 
modifyStateIfRetryRequired(org.apache.gobblin.configuration.
     return new org.apache.gobblin.configuration.State(mergedState);
   }
 
+  /**
+   * Events with different `currentAttempts` may arrive out of order and we 
should use the max of both the counts to
+   * set the new value of `currentAttempts`. However, when a flow is resumed, 
it sends an event with count=0 and at that
+   * time, we should update it to zero. Because events can arrive out of 
order, we must do this only when the event with

Review comment:
       is it retry vs resume of flow execution?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to