aplex commented on a change in pull request #3299:
URL: https://github.com/apache/gobblin/pull/3299#discussion_r669187949
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-api/src/main/pegasus/org/apache/gobblin/service/Issue.pdl
##########
@@ -0,0 +1,46 @@
+namespace org.apache.gobblin.service
+
+/**
+ * Issue describes a specific unique problem in the job or application.
+ *
+ * Issue can be generated from log entries, health checks, and other places.
+ */
+record Issue {
+
+ /**
+ * Time when the issue have occured
+ */
+ time: Timestamp
Review comment:
It's actually unclear what "long" means for Time. In the most common
interpretation, unix timestamp is a number of seconds since 1970, but in our
API it is milliseconds. Having a type reference with a description of what it
means should be more clear. Timestamp type comment says that it is in
milliseconds.
Personally, I think we should have used ISO format like
"2015-04-14T11:07:36.639Z" that is both human- and computer- readable, but it's
too late to change it since other parts of API use timestamps.
https://stackoverflow.com/a/29626123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
