umustafi commented on a change in pull request #3345:
URL: https://github.com/apache/gobblin/pull/3345#discussion_r681322550
##########
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
##########
@@ -253,8 +259,16 @@ public GobblinYarnAppLauncher(Config config,
YarnConfiguration yarnConfiguration
YarnHelixUtils.setYarnClassPath(config, this.yarnConfiguration);
YarnHelixUtils.setAdditionalYarnClassPath(config, this.yarnConfiguration);
this.yarnConfiguration.set("fs.automatic.close", "false");
- this.yarnClient = YarnClient.createYarnClient();
- this.yarnClient.init(this.yarnConfiguration);
+ this.originalYarnRMAddress =
this.yarnConfiguration.get(GobblinYarnConfigurationKeys.YARN_RESOURCE_MANAGER_ADDRESS);
+ this.potentialYarnClients = new HashMap();
+ Set<String> potentialRMAddresses = new
HashSet<>(ConfigUtils.getStringList(config,
GobblinYarnConfigurationKeys.OTHER_YARN_RESOURCE_MANAGER_ADDRESSES));
+ potentialRMAddresses.add(originalYarnRMAddress);
+ for (String rmAddress : potentialRMAddresses) {
+ YarnClient tmpYarnClient = YarnClient.createYarnClient();
Review comment:
nit but i think the spacing is off here - Alex told me to run "silent
code cleanup" in Intellij on blocks of code we change to auto correct these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
