[
https://issues.apache.org/jira/browse/GOBBLIN-1500?focusedWorklogId=632629&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-632629
]
ASF GitHub Bot logged work on GOBBLIN-1500:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Aug/21 23:07
Start Date: 02/Aug/21 23:07
Worklog Time Spent: 10m
Work Description: umustafi commented on a change in pull request #3345:
URL: https://github.com/apache/gobblin/pull/3345#discussion_r681322550
##########
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
##########
@@ -253,8 +259,16 @@ public GobblinYarnAppLauncher(Config config,
YarnConfiguration yarnConfiguration
YarnHelixUtils.setYarnClassPath(config, this.yarnConfiguration);
YarnHelixUtils.setAdditionalYarnClassPath(config, this.yarnConfiguration);
this.yarnConfiguration.set("fs.automatic.close", "false");
- this.yarnClient = YarnClient.createYarnClient();
- this.yarnClient.init(this.yarnConfiguration);
+ this.originalYarnRMAddress =
this.yarnConfiguration.get(GobblinYarnConfigurationKeys.YARN_RESOURCE_MANAGER_ADDRESS);
+ this.potentialYarnClients = new HashMap();
+ Set<String> potentialRMAddresses = new
HashSet<>(ConfigUtils.getStringList(config,
GobblinYarnConfigurationKeys.OTHER_YARN_RESOURCE_MANAGER_ADDRESSES));
+ potentialRMAddresses.add(originalYarnRMAddress);
+ for (String rmAddress : potentialRMAddresses) {
+ YarnClient tmpYarnClient = YarnClient.createYarnClient();
Review comment:
nit but i think the spacing is off here - Alex told me to run "silent
code cleanup" in Intellij on blocks of code we change to auto correct these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 632629)
Time Spent: 1h 50m (was: 1h 40m)
> Support gobblin on yarn to be able to run on clusters with robin enabled
> ------------------------------------------------------------------------
>
> Key: GOBBLIN-1500
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1500
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Previously we always check with one default yarn client, but if the cluster
> is enabled with Robin and can connect to different RM, it will ends up we
> cannot find existing application and submit duplicate tasks. So now we need
> to check against different potential yarn cluster, and also make sure when
> submitting yarn application, we only have one RM token.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
