sv2000 commented on a change in pull request #3370:
URL: https://github.com/apache/gobblin/pull/3370#discussion_r692532012
##########
File path:
gobblin-runtime/src/test/java/org/apache/gobblin/runtime/api/FsSpecProducerTest.java
##########
@@ -106,4 +131,19 @@ public void testDeleteSpec() throws URISyntaxException,
ExecutionException, Inte
Assert.assertEquals(jobSpecs.get(0).getLeft(), SpecExecutor.Verb.DELETE);
Assert.assertEquals(jobSpecs.get(0).getRight().getUri().toString(),
"testDeleteJob");
}
+
+ class TestingFsSpecProducer extends FsSpecProducer {
Review comment:
Can we simply write a dummy file (e.g. using File API) into the spec
path without having to extend FsSpecProducer class? We can avoid having to make
the annotateSpecFilename method package-private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
