[
https://issues.apache.org/jira/browse/GOBBLIN-1530?focusedWorklogId=645646&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-645646
]
ASF GitHub Bot logged work on GOBBLIN-1530:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Sep/21 00:34
Start Date: 02/Sep/21 00:34
Worklog Time Spent: 10m
Work Description: Will-Lo commented on a change in pull request #3381:
URL: https://github.com/apache/gobblin/pull/3381#discussion_r700661656
##########
File path:
gobblin-service/src/test/java/org/apache/gobblin/service/modules/flow/MultiHopFlowCompilerTest.java
##########
@@ -670,6 +670,28 @@ public void testUnresolvedFlow() throws Exception {
spec.getCompilationErrors().stream().anyMatch(s ->
s.contains(AzkabanProjectConfig.USER_TO_PROXY));
}
+ @Test (dependsOnMethods = "testUnresolvedFlow")
+ public void testMissingSourceNodeError() throws Exception {
+ FlowSpec spec = createFlowSpec("flow/flow5.conf", "HDFS-NULL", "HDFS-3",
false, false);
+
+ Dag<JobExecutionPlan> dag = specCompiler.compileFlow(spec);
+
+ Assert.assertEquals(dag, null);
+ Assert.assertEquals(spec.getCompilationErrors().size(), 1);
+ spec.getCompilationErrors().stream().anyMatch(s -> s.contains("Flowgraph
does not have a node with id"));
+ }
+
+ @Test (dependsOnMethods = "testMissingSourceNodeError")
+ public void testMissingDestinationNodeError() throws Exception {
Review comment:
Ah my bad I added that way too fast, good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 645646)
Time Spent: 1h 40m (was: 1.5h)
> Add better error reporting when a node does not exist in GaaS
> -------------------------------------------------------------
>
> Key: GOBBLIN-1530
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1530
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> When a source node does not exist on the flowGraph, a very cryptic error
> appears when sending a request:
> {code:java}
> serviceErrorMessage: Flow was not compiled successfully. Compilation errors
> encountered: [java.lang.RuntimeException: java.lang.NullPointerException
> 24-08-2021 13:21:37 PDT backup-crosscluster-job INFO - at t
> org.apache.gobblin.service.modules.flow.MultiHopFlowCompiler.compileFlow(MultiHopFlowCompiler.java:206)
> 24-08-2021 13:21:37 PDT backup-crosscluster-job INFO - at
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
