Will-Lo commented on a change in pull request #3381:
URL: https://github.com/apache/gobblin/pull/3381#discussion_r701255769
##########
File path:
gobblin-service/src/test/java/org/apache/gobblin/service/modules/flow/MultiHopFlowCompilerTest.java
##########
@@ -670,6 +670,28 @@ public void testUnresolvedFlow() throws Exception {
spec.getCompilationErrors().stream().anyMatch(s ->
s.contains(AzkabanProjectConfig.USER_TO_PROXY));
}
+ @Test (dependsOnMethods = "testUnresolvedFlow")
+ public void testMissingSourceNodeError() throws Exception {
+ FlowSpec spec = createFlowSpec("flow/flow5.conf", "HDFS-NULL", "HDFS-3",
false, false);
+
+ Dag<JobExecutionPlan> dag = specCompiler.compileFlow(spec);
+
+ Assert.assertEquals(dag, null);
+ Assert.assertEquals(spec.getCompilationErrors().size(), 1);
+ spec.getCompilationErrors().stream().anyMatch(s -> s.contains("Flowgraph
does not have a node with id"));
+ }
+
+ @Test (dependsOnMethods = "testMissingSourceNodeError")
+ public void testMissingDestinationNodeError() throws Exception {
Review comment:
@jack-moseley you're right, it reports the error correctly on local
which is what I tested, but when we add our dmas authorizer it runs into the
nullpointer exception before it does another check when calculating the path,
I'll add the error check now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
