jack-moseley opened a new pull request #3386: URL: https://github.com/apache/gobblin/pull/3386
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-1534 ### Description - [x] Here are some details about my PR, including screenshots (if applicable): Currently in both gaas and jobs launched by gaas, we use kafka event reporting, but not kafka metrics reporting. In #3035, there were some changes which includes splitting the kafka reporter factory. As a side effect, the two reporters (metrics/events) became all or nothing, where previously if just one was missing config it would be skipped. This causes gaas and jobs launched by gaas to always contain an error stacktrace about failing to instantiate the kafka metric reporter. This PR adds config keys to enable/disable the reporters individually. For backwards compatibility, if `metrics.reporting.kafka.enabled` is true, they will both be enabled. ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: Tested in local gaas ### Commits - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
