aplex commented on a change in pull request #3387:
URL: https://github.com/apache/gobblin/pull/3387#discussion_r704894742
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/trash/TrashFactory.java
##########
@@ -59,19 +59,12 @@ public static Trash createTrash(FileSystem fs, Properties
props) throws IOExcept
*/
public static Trash createTrash(FileSystem fs, Properties props, String user)
throws IOException {
- if(props.containsKey(TRASH_TEST) &&
Boolean.parseBoolean(props.getProperty(TRASH_TEST))) {
- LOG.info("Creating a test trash. Nothing will actually be deleted.");
- return new TestTrash(fs, props, user);
- }
- if(props.containsKey(SIMULATE) &&
Boolean.parseBoolean(props.getProperty(SIMULATE))) {
- LOG.info("Creating a simulate trash. Nothing will actually be deleted.");
- return new MockTrash(fs, props, user);
- }
- if(props.containsKey(SKIP_TRASH) &&
Boolean.parseBoolean(props.getProperty(SKIP_TRASH))) {
Review comment:
Looks like we no longer handle SKIP_TRASH and SIMULATE, and replace them
with custom trash classes. Is there any effect on existing jobs/backward
compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
