[
https://issues.apache.org/jira/browse/GOBBLIN-1547?focusedWorklogId=652396&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652396
]
ASF GitHub Bot logged work on GOBBLIN-1547:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Sep/21 17:22
Start Date: 17/Sep/21 17:22
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on a change in pull request #3398:
URL: https://github.com/apache/gobblin/pull/3398#discussion_r711216983
##########
File path:
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/writer/IcebergMetadataWriter.java
##########
@@ -729,9 +729,9 @@ private StructLike
addLatePartitionValueToIcebergTable(Table table, TableMetadat
private int isLate(String datepartition, long previousWatermark) {
ZonedDateTime partitionDateTime = ZonedDateTime.parse(datepartition,
HOURLY_DATEPARTITION_FORMAT);
long partitionEpochTime = partitionDateTime.toInstant().toEpochMilli();
- if(partitionEpochTime > previousWatermark) {
+ if(partitionEpochTime >= previousWatermark) {
Review comment:
Why do we change this part? If current watermark is 09am, does that mean
data for 09 has completed? And then if we see dat for 09am, is that a late
data?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 652396)
Time Spent: 20m (was: 10m)
> Change completion watermark to end of hour
> ------------------------------------------
>
> Key: GOBBLIN-1547
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1547
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
