[
https://issues.apache.org/jira/browse/GOBBLIN-1561?focusedWorklogId=665453&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-665453
]
ASF GitHub Bot logged work on GOBBLIN-1561:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Oct/21 00:22
Start Date: 14/Oct/21 00:22
Worklog Time Spent: 10m
Work Description: codecov-commenter edited a comment on pull request
#3412:
URL: https://github.com/apache/gobblin/pull/3412#issuecomment-942816158
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3412?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3412](https://codecov.io/gh/apache/gobblin/pull/3412?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(b10b87e) into
[master](https://codecov.io/gh/apache/gobblin/commit/a1b0b9e2eda43e0f518a35ac211844ac73b4cdd6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(a1b0b9e) will **decrease** coverage by `3.88%`.
> The diff coverage is `18.18%`.
[](https://codecov.io/gh/apache/gobblin/pull/3412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3412 +/- ##
============================================
- Coverage 46.48% 42.59% -3.89%
+ Complexity 10250 4629 -5621
============================================
Files 2064 1035 -1029
Lines 80587 41317 -39270
Branches 8999 4594 -4405
============================================
- Hits 37457 17601 -19856
+ Misses 39659 21965 -17694
+ Partials 3471 1751 -1720
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...blin/service/FlowConfigV2ResourceLocalHandler.java](https://codecov.io/gh/apache/gobblin/pull/3412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJSZXNvdXJjZUxvY2FsSGFuZGxlci5qYXZh)
| `0.00% <0.00%> (ø)` | |
|
[...lin/service/modules/flow/MultiHopFlowCompiler.java](https://codecov.io/gh/apache/gobblin/pull/3412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93L011bHRpSG9wRmxvd0NvbXBpbGVyLmphdmE=)
| `70.70% <50.00%> (ø)` | |
|
[...dules/flowgraph/pathfinder/AbstractPathFinder.java](https://codecov.io/gh/apache/gobblin/pull/3412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvcGF0aGZpbmRlci9BYnN0cmFjdFBhdGhGaW5kZXIuamF2YQ==)
| `87.06% <100.00%> (ø)` | |
|
[...ava/org/apache/gobblin/fsm/FiniteStateMachine.java](https://codecov.io/gh/apache/gobblin/pull/3412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZzbS9GaW5pdGVTdGF0ZU1hY2hpbmUuamF2YQ==)
| `73.48% <0.00%> (-3.04%)` | :arrow_down: |
|
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/gobblin/pull/3412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `61.42% <0.00%> (-1.43%)` | :arrow_down: |
|
[.../apache/gobblin/compaction/hive/HiveAttribute.java](https://codecov.io/gh/apache/gobblin/pull/3412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vaGl2ZS9IaXZlQXR0cmlidXRlLmphdmE=)
| | |
|
[...ersion/hive/watermarker/TableLevelWatermarker.java](https://codecov.io/gh/apache/gobblin/pull/3412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS93YXRlcm1hcmtlci9UYWJsZUxldmVsV2F0ZXJtYXJrZXIuamF2YQ==)
| | |
|
[.../extractor/filebased/FileBasedHelperException.java](https://codecov.io/gh/apache/gobblin/pull/3412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZmlsZWJhc2VkL0ZpbGVCYXNlZEhlbHBlckV4Y2VwdGlvbi5qYXZh)
| | |
|
[...ava/org/apache/gobblin/hive/HiveRegisterUtils.java](https://codecov.io/gh/apache/gobblin/pull/3412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL0hpdmVSZWdpc3RlclV0aWxzLmphdmE=)
| | |
|
[...ement/policy/EmbeddedRetentionSelectionPolicy.java](https://codecov.io/gh/apache/gobblin/pull/3412/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3BvbGljeS9FbWJlZGRlZFJldGVudGlvblNlbGVjdGlvblBvbGljeS5qYXZh)
| | |
| ... and [1024
more](https://codecov.io/gh/apache/gobblin/pull/3412/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3412?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3412?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[a1b0b9e...b10b87e](https://codecov.io/gh/apache/gobblin/pull/3412?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 665453)
Time Spent: 40m (was: 0.5h)
> Improve error message when flow compilation fails
> -------------------------------------------------
>
> Key: GOBBLIN-1561
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1561
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When flow compilation fails, it prints a large list of irrelevant configs
> that are missing from different edges. The reason for this is that the
> pathfinding does not know what the intended path was, so it doesn't know
> which edges were actually missing required config. For example, this create
> flow command:
> {code:java}
> curli --dv-auth SELF --fabric ei-ltx1 "d2://sharedFlowconfigsV2" -X POST -H
> 'X-RestLi-Method: create' -H 'X-RestLi-Protocol-Version: 2.0.0' --data
> '{"id": {"flowName": "test123", "flowGroup": "test123"}, "properties":
> {"gobblin.flow.sourceIdentifier": "faro",
> "gobblin.flow.destinationIdentifier": "faro", "user.to.proxy": "gobblintest",
> "gobblin.flow.input.dataset.descriptor.path": "/tmp/gaas-cli-test/a",
> "gobblin.flow.output.dataset.descriptor.path": "/tmp/gaas-cli-test/a",
> "gobblin.flow.input.dataset.descriptor.partition.type": "none",
> "gobblin.flow.output.dataset.descriptor.partition.type": "none",
> "report.job.progress": "true", "flow.applyRetention": "true",
> "flow.applyInputRetention": "true",
> "gobblin.retention.newestK.versions.retained": "0",
> "dataset.datetimePattern": "yyyy/MM/dd", "copy.date.pattern": "yyyy/MM/dd"},
> "templateUris": "FS:///"}'
> {code}
> Fails because the "version.finder" property is unresolved for the
> faro_faro_retention edge, but that info is buried in this large error message:
> {code:java}
> "Flow was not compiled successfully. Compilation errors encountered: [Error
> compiling edge
> faro_azureLnkdKtwoAdls2_inter-cluster-datetime-file-based-gen2-copy-azure:
> com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 3: Could
> not resolve substitution to a value: ${azure.container}, Error compiling edge
> faro_azureLnkdAdls2_single-hop-selfserve-unixts-file-based-gen2-copy-azure:
> com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 3: Could
> not resolve substitution to a value: ${azure.container}, Error compiling edge
> faro_azureScusAdls2-data_inter-cluster-file-based-copy-azure:
> com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 10: Could
> not resolve substitution to a value: ${destination.adl.token.type}, Error
> compiling edge
> faro_azureLnkdArchAdls2_inter-cluster-file-based-gen2-copy-azure:
> com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 3: Could
> not resolve substitution to a value: ${azure.container}, Error compiling edge
> faro_azureLnkdAdls2_single-hop-selfserve-timeaware-file-based-gen2-copy-azure:
> com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 3: Could
> not resolve substitution to a value: ${azure.container}, Error compiling edge
> faro_faro_retention:
> com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 67: Could
> not resolve substitution to a value: ${version.finder}, No path found from
> source: faro and destination: faro, Error compiling edge
> faro_azureLnkdArchAdls2_inter-cluster-datetime-file-based-gen2-copy-azure:
> com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 3: Could
> not resolve substitution to a value: ${azure.container}, Error compiling edge
> faro_azureLnkdAdls2_single-hop-selfserve-glob-file-based-gen2-copy-azure:
> com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 3: Could
> not resolve substitution to a value: ${azure.container}, Error compiling edge
> faro_azureLnkdKtwoAdls2_inter-cluster-file-based-gen2-copy-azure:
> com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 3: Could
> not resolve substitution to a value: ${azure.container}, Error compiling edge
> faro_azureLnkdKtwoAdls2_inter-cluster-regex-file-based-gen2-copy-azure:
> com.typesafe.config.ConfigException$UnresolvedSubstitution: Reader: 3: Could
> not resolve substitution to a value: ${azure.container}]"{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
