phet commented on a change in pull request #3416:
URL: https://github.com/apache/gobblin/pull/3416#discussion_r732155066
##########
File path:
gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/reporter/EventReporter.java
##########
@@ -144,9 +145,11 @@ public void notificationCallback(Notification
notification) {
*/
public void addEventToReportingQueue(GobblinTrackingEvent event) {
Review comment:
sorry, re-reading I see my reminder was poorly phrased.
just pointing out that derived classes, like `FFER`, only conditionally call
the method you added logging to. `KER` does not even override (so no current
issue)... merely reminding in general that non-`final` code may not actually
run, and to keep in mind, if things look off while later debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
