[
https://issues.apache.org/jira/browse/GOBBLIN-1552?focusedWorklogId=678877&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-678877
]
ASF GitHub Bot logged work on GOBBLIN-1552:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/21 02:45
Start Date: 09/Nov/21 02:45
Worklog Time Spent: 10m
Work Description: phet commented on a change in pull request #3403:
URL: https://github.com/apache/gobblin/pull/3403#discussion_r745242964
##########
File path:
gobblin-runtime/src/test/java/org/apache/gobblin/service/monitoring/FlowStatusGeneratorTest.java
##########
@@ -106,10 +108,13 @@ public void testGetFlowStatusesAcrossGroup() {
f0Js2Status, f0Js2Tag, f0Js2JobGroup1, f0Js2JobName1, JOB_EXEC_ID);
// IMPORTANT: result invariants to honor - ordered by ascending flowName,
all of same flowName adjacent, therein descending flowExecutionId
- // NOTE: `Supplier`/thunk needed for repeated use, due to mutable,
non-rewinding `Iterator FlowStatus.getJobStatusIterator`
- Supplier<FlowStatus> createFs1 = () -> createFlowStatus(flowGroup,
flowName1, flowExecutionId1, Arrays.asList(f1Js0, f1Js1, f1Js2));
-
Mockito.when(jobStatusRetriever.getFlowStatusesForFlowGroupExecutions(flowGroup,
countPerFlowName)).thenReturn(
- Arrays.asList(createFs1.get()), Arrays.asList(createFs1.get()),
Arrays.asList(createFs1.get())); // (for three invocations)
+ // NOTE: Three copies of FlowStatus are needed for repeated use, due to
mutable, non-rewinding `Iterator FlowStatus.getJobStatusIterator`
+//
Mockito.when(JobStatusRetriever.getFlowStatusFromJobStatuses(anyBoolean(),
any())).thenReturn(ExecutionStatus.RUNNING);
Review comment:
did this commented-out code sneak in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 678877)
Time Spent: 4h 10m (was: 4h)
> fix flow status reporting when dag manager is not enabled
> ---------------------------------------------------------
>
> Key: GOBBLIN-1552
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1552
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> flow status is determined by looking at the flow level events. but flow level
> events are not emitted outside of dag manager. so currently flow status is
> not being determined correctly when dag manager is disabled
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
