[
https://issues.apache.org/jira/browse/GOBBLIN-1584?focusedWorklogId=691327&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-691327
]
ASF GitHub Bot logged work on GOBBLIN-1584:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/21 20:08
Start Date: 06/Dec/21 20:08
Worklog Time Spent: 10m
Work Description: umustafi commented on a change in pull request #3438:
URL: https://github.com/apache/gobblin/pull/3438#discussion_r763348629
##########
File path:
gobblin-modules/gobblin-sql/src/main/java/org/apache/gobblin/writer/commands/BaseJdbcBufferedInserter.java
##########
@@ -80,6 +85,8 @@ public BaseJdbcBufferedInserter(State state, Connection conn)
{
this.retryer = RetryerBuilder.<Boolean> newBuilder().retryIfException()
.withWaitStrategy(WaitStrategies.exponentialWait(1000, maxWait,
TimeUnit.SECONDS))
.withStopStrategy(StopStrategies.stopAfterAttempt(maxAttempts)).build();
+
+ this.replaceExistingValues =
state.getPropAsBoolean(ConfigurationKeys.ALLOW_DATA_OVERWRITE);
Review comment:
I haven't added the "fail fast" logic in the other child classes that do
not have any functionality implemented for this. If the config is true should
the job fail in the constructor or at the time of writing `(initialize batch)`
or should I add documentation that the logic does not exist and allow the job
to succeed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 691327)
Time Spent: 2h 50m (was: 2h 40m)
> Add Replace Logic To Mysql Writer
> ---------------------------------
>
> Key: GOBBLIN-1584
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1584
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> We only support {{insertion}} of new values into tables, not
> {{{}update/upsert{}}}. If you run an ingestion job with a record containing a
> record with the same primary key the whole job will fail because of the
> duplicate entry. We don't expect ingestion jobs to always contain _only new_
> records, so we should handle duplicate entries, ingestion of data already in
> the table or updates to old values. The insert vs. replace logic should be
> configurable to the user as well.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
