[
https://issues.apache.org/jira/browse/GOBBLIN-1585?focusedWorklogId=694195&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-694195
]
ASF GitHub Bot logged work on GOBBLIN-1585:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Dec/21 20:06
Start Date: 10/Dec/21 20:06
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on a change in pull request #3439:
URL: https://github.com/apache/gobblin/pull/3439#discussion_r766948474
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/spec/JobExecutionPlan.java
##########
@@ -65,6 +65,7 @@
private final SpecExecutor specExecutor;
private ExecutionStatus executionStatus = ExecutionStatus.PENDING;
private final int maxAttempts;
+ private int currentGeneration = 1;
private int currentAttempts = 0;
Review comment:
1. we only increase the number of current generation when we send
pending resume, and for currentAttempts, we increase it every time we call
orchestrated. So for the first attempt, once we orchestrate it, the current
attempt and current generation will all be 1. Before first job orchestrated,
when the job status is pending, it will be 1 generation and 0 attempts.
2. No, both of the default value is 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 694195)
Time Spent: 4h (was: 3h 50m)
> GaaS (DagManager) keep retrying a failed job beyond max attempt number
> ----------------------------------------------------------------------
>
> Key: GOBBLIN-1585
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1585
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> The issue is that for the same flow execution, we don't receive the event in
> order. if the job fail and we retry, we may receive running event first, and
> then the Orchestrate event which update the current attempts and should retry
> value will be ignored and cause to job to continually try to retrying util
> the running job finished.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
