phet commented on a change in pull request #3439:
URL: https://github.com/apache/gobblin/pull/3439#discussion_r768246260
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagerUtils.java
##########
@@ -236,6 +243,13 @@ static void incrementJobAttempt(DagNode<JobExecutionPlan>
dagNode) {
dagNode.getValue().setCurrentAttempts(dagNode.getValue().getCurrentAttempts() +
1);
}
+ /**
+ * Increment the value of {@link JobExecutionPlan#currentGeneration}
Review comment:
I read the code to confirm the other day... but then forgot to mention
during my prior review.
small suggestion: you could leave a comment clarifying this is thread safe
by reminding the reader that `Dag`s are consistently assigned to a single
`DagManagerThread` on the basis of the execution ID
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
