[
https://issues.apache.org/jira/browse/GOBBLIN-1596?focusedWorklogId=708751&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-708751
]
ASF GitHub Bot logged work on GOBBLIN-1596:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jan/22 00:18
Start Date: 14/Jan/22 00:18
Worklog Time Spent: 10m
Work Description: codecov-commenter edited a comment on pull request
#3451:
URL: https://github.com/apache/gobblin/pull/3451#issuecomment-1012499004
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3451?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3451](https://codecov.io/gh/apache/gobblin/pull/3451?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(d723cb4) into
[master](https://codecov.io/gh/apache/gobblin/commit/26f69301b0ad160ca869140c31a4ccc400949225?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(26f6930) will **decrease** coverage by `3.14%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/gobblin/pull/3451?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3451 +/- ##
============================================
- Coverage 46.61% 43.47% -3.15%
+ Complexity 10342 2031 -8311
============================================
Files 2074 404 -1670
Lines 80956 17382 -63574
Branches 9030 2124 -6906
============================================
- Hits 37740 7557 -30183
+ Misses 39741 8988 -30753
+ Partials 3475 837 -2638
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3451?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/gobblin/pull/3451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `40.00% <0.00%> (-20.00%)` | :arrow_down: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/gobblin/pull/3451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `92.85% <0.00%> (-7.15%)` | :arrow_down: |
|
[...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/gobblin/pull/3451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==)
| `29.93% <0.00%> (-0.66%)` | :arrow_down: |
|
[...lin/hive/metastore/HiveMetaStoreBasedRegister.java](https://codecov.io/gh/apache/gobblin/pull/3451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL21ldGFzdG9yZS9IaXZlTWV0YVN0b3JlQmFzZWRSZWdpc3Rlci5qYXZh)
| | |
|
[...conversion/hive/materializer/HiveMaterializer.java](https://codecov.io/gh/apache/gobblin/pull/3451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9tYXRlcmlhbGl6ZXIvSGl2ZU1hdGVyaWFsaXplci5qYXZh)
| | |
|
[.../org/apache/gobblin/metrics/ContextAwareTimer.java](https://codecov.io/gh/apache/gobblin/pull/3451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Db250ZXh0QXdhcmVUaW1lci5qYXZh)
| | |
|
[...ion/hive/converter/AbstractAvroToOrcConverter.java](https://codecov.io/gh/apache/gobblin/pull/3451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9jb252ZXJ0ZXIvQWJzdHJhY3RBdnJvVG9PcmNDb252ZXJ0ZXIuamF2YQ==)
| | |
|
[.../org/apache/gobblin/runtime/SafeDatasetCommit.java](https://codecov.io/gh/apache/gobblin/pull/3451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvU2FmZURhdGFzZXRDb21taXQuamF2YQ==)
| | |
|
[...che/gobblin/type/SerializedRecordWithMetadata.java](https://codecov.io/gh/apache/gobblin/pull/3451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tbWV0YWRhdGEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdHlwZS9TZXJpYWxpemVkUmVjb3JkV2l0aE1ldGFkYXRhLmphdmE=)
| | |
|
[...data/management/policy/NewestKSelectionPolicy.java](https://codecov.io/gh/apache/gobblin/pull/3451/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3BvbGljeS9OZXdlc3RLU2VsZWN0aW9uUG9saWN5LmphdmE=)
| | |
| ... and [1663
more](https://codecov.io/gh/apache/gobblin/pull/3451/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3451?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3451?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[26f6930...d723cb4](https://codecov.io/gh/apache/gobblin/pull/3451?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 708751)
Time Spent: 1h 10m (was: 1h)
> Ignore table AlreadyExistsException when adding a partition
> -----------------------------------------------------------
>
> Key: GOBBLIN-1596
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1596
> Project: Apache Gobblin
> Issue Type: Task
> Components: gobblin-core
> Affects Versions: 0.16.0
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Hive Registration throws an error when creating a table to add partitions to,
> if the table already exists. Although we should have locks to prevent this,
> we can't guard against other jobs that could also cause a race condition too.
> We can ignore the exception in the error handling for
> `ensureHiveTableExistenceBeforeAlternation`
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
