[
https://issues.apache.org/jira/browse/GOBBLIN-1598?focusedWorklogId=713140&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-713140
]
ASF GitHub Bot logged work on GOBBLIN-1598:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/22 00:14
Start Date: 22/Jan/22 00:14
Worklog Time Spent: 10m
Work Description: ZihanLi58 opened a new pull request #3454:
URL: https://github.com/apache/gobblin/pull/3454
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1598
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
2021/06/12 07:11:32.067 ERROR [DagManager] [pool-19-thread-3]
[gobblin-service-war] [] Exception encountered in
org.apache.gobblin.service.modules.orchestration.DagManager$DagManagerThread
java.lang.IllegalArgumentException: A metric named
GobblinService.testFlow.RunningStatus already exists
at
org.apache.gobblin.metrics.InnerMetricContext.register(InnerMetricContext.java:266)
Likely root cause:
If we activate/deactivate DagManager several times, DagManagerThreads
alongside with their flowGauges maps will be recreated, but RootMetricContext
will still stay the same. So the newly created threads will incorrectly think
that the flow was not registered previously, and try to register it again.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Unit tests
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 713140)
Remaining Estimate: 0h
Time Spent: 10m
> Fix metrics already exist issue in dag manager
> ----------------------------------------------
>
> Key: GOBBLIN-1598
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1598
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code:java}
> 2021/06/12 07:11:32.067 ERROR [DagManager] [pool-19-thread-3]
> [gobblin-service-war] [] Exception encountered in
> org.apache.gobblin.service.modules.orchestration.DagManager$DagManagerThread
> java.lang.IllegalArgumentException: A metric named
> GobblinService.testGroup.testFlow.RunningStatus already exists
> at
> org.apache.gobblin.metrics.InnerMetricContext.register(InnerMetricContext.java:266)
>
> at org.apache.gobblin.metrics.MetricContext.register(MetricContext.java:409)
> at
> org.apache.gobblin.service.modules.orchestration.DagManager$DagManagerThread.initialize(DagManager.java:661)
>
> at
> org.apache.gobblin.service.modules.orchestration.DagManager$DagManagerThread.run(DagManager.java:493)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> [?:1.8.0_172]
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> [?:1.8.0_172]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> [?:1.8.0_172]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> [?:1.8.0_172]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [?:1.8.0_172]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [?:1.8.0_172]
> at java.lang.Thread.run(Thread.java:748) [?:1.8.0_172]
> {code}
> Likely root cause:
> If we activate/deactivate DagManager several times, DagManagerThreads
> alongside with their flowGauges maps will be recreated, but RootMetricContext
> will still stay the same. So the newly created threads will incorrectly think
> that the flow was not registered previously, and try to register it again.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
