ZihanLi58 commented on a change in pull request #3459:
URL: https://github.com/apache/gobblin/pull/3459#discussion_r801078196
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/hive/HivePartitionFileSet.java
##########
@@ -99,7 +99,7 @@ public HivePartitionFileSet(HiveCopyEntityHelper
hiveCopyEntityHelper, Partition
hiveCopyEntityHelper.getExistingEntityPolicy() !=
HiveCopyEntityHelper.ExistingEntityPolicy.REPLACE_TABLE_AND_PARTITIONS) {
log.error("Source and target partitions are not compatible.
Aborting copy of partition " + this.partition,
ioe);
- return Lists.newArrayList();
+ throw ioe;
Review comment:
"control whether to fail loudly or not with an override policy" this is
the configure I was referring, if we can do that already, this change is much
low-risk than I thought. thanks for clarification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
