[
https://issues.apache.org/jira/browse/GOBBLIN-1606?focusedWorklogId=723067&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-723067
]
ASF GitHub Bot logged work on GOBBLIN-1606:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Feb/22 18:35
Start Date: 08/Feb/22 18:35
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on a change in pull request #3464:
URL: https://github.com/apache/gobblin/pull/3464#discussion_r801943970
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/writer/FileAwareInputStreamDataWriter.java
##########
@@ -161,6 +161,9 @@ public FileAwareInputStreamDataWriter(State state,
FileSystem fileSystem, int nu
this.recoveryHelper = new RecoveryHelper(this.fs, state);
this.actualProcessedCopyableFile = Optional.absent();
+ if
(getMetricContext().getInnerMetricContext().getContextAwareMetrics().containsKey(GOBBLIN_COPY_BYTES_COPIED_METER))
{
Review comment:
Also you can directly getMetricContext().getMetrics() to get the metrics
map instead of accessing innerMetricContext?
##########
File path:
gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/InnerMetricContext.java
##########
@@ -71,6 +71,7 @@
// A map from simple names to context-aware metrics. All metrics registered
with this context (using
// their simple names) are also registered with the MetricRegistry using
their fully-qualified names.
+ @Getter
Review comment:
Same as above comment, this seems not needed
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/writer/FileAwareInputStreamDataWriter.java
##########
@@ -161,6 +161,9 @@ public FileAwareInputStreamDataWriter(State state,
FileSystem fileSystem, int nu
this.recoveryHelper = new RecoveryHelper(this.fs, state);
this.actualProcessedCopyableFile = Optional.absent();
+ if
(getMetricContext().getInnerMetricContext().getContextAwareMetrics().containsKey(GOBBLIN_COPY_BYTES_COPIED_METER))
{
Review comment:
Can you add comment to explain why we want to remove this metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 723067)
Remaining Estimate: 0h
Time Spent: 10m
> set default value for check_file_size to true
> ---------------------------------------------
>
> Key: GOBBLIN-1606
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1606
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
