Will-Lo commented on a change in pull request #3461:
URL: https://github.com/apache/gobblin/pull/3461#discussion_r803144337
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/CopySource.java
##########
@@ -291,6 +292,20 @@ private void
submitUnfulfilledRequestEventsHelper(List<FileSet<CopyEntity>> file
}
}
+ void failJobIfAllRequestsRejected(RequestAllocator<FileSet<CopyEntity>>
allocator,
+ Iterator<FileSet<CopyEntity>> allocatedRequests) throws IOException {
+ // TODO: we should set job as partial success if there is a mix of
allocated requests and rejections
Review comment:
I realize that we don't have a job status specifically for partial
success, it ends up being marked as a total success unless there is a partial
job commit policy. Should we change this to be if the job policy is marked as
partial success, then it would pass?
We only have the following states so far:
```
PREPARING, RUNNING, INTERRUPTED, CANCELLED, SUCCESS, FAILED
```
So adding a new state would be part of a larger change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
