[
https://issues.apache.org/jira/browse/GOBBLIN-1608?focusedWorklogId=724891&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-724891
]
ASF GitHub Bot logged work on GOBBLIN-1608:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/22 02:00
Start Date: 11/Feb/22 02:00
Worklog Time Spent: 10m
Work Description: jack-moseley opened a new pull request #3466:
URL: https://github.com/apache/gobblin/pull/3466
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1608
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
When `max.error.dateset` is reached and the container is failed, gobblin
will cause close() on the writer, which will call flush(). This causes a couple
issues with events due to assumptions on where flush() is called.
- Move `tableOperationTypeMap.remove(tableString)` to before the container
is failed, otherwise an extra flush() will be called on the table. This flush()
shouldn't actually do anything since writer.reset has been called for the
dataset already.
- Don't send error GTEs for all tables if flush() is called from close().
This event emission is here because GMCE watermark is advanced when flush() is
called periodically, but when flush() is called from close the watermark is not
advanced so events should not be sent.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Tested with one dataset in e2e pipeline.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 724891)
Remaining Estimate: 0h
Time Spent: 10m
> Fix case where error GTE is incorrectly sent from MCE writer
> ------------------------------------------------------------
>
> Key: GOBBLIN-1608
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1608
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
