ZihanLi58 commented on a change in pull request #3474:
URL: https://github.com/apache/gobblin/pull/3474#discussion_r817223365
##########
File path:
gobblin-core/src/main/java/org/apache/gobblin/source/extractor/extract/restapi/RestApiConnector.java
##########
@@ -77,6 +82,15 @@ public RestApiConnector(State state) {
state.getPropAsInt(ConfigurationKeys.SOURCE_CONN_TIMEOUT,
ConfigurationKeys.DEFAULT_CONN_TIMEOUT);
}
+ @Override
+ public void close() throws IOException {
Review comment:
For all restApiExtractor which may contain this connect, we expect the
closeConnection method will close the connector. Will update PR to include this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
