abhishekdas99 commented on a change in pull request #3475:
URL: https://github.com/apache/gobblin/pull/3475#discussion_r819982905
##########
File path:
gobblin-core/src/main/java/org/apache/gobblin/writer/FsDataWriter.java
##########
@@ -266,7 +267,7 @@ public void commit()
LOG.info(String.format("Moving data from %s to %s", this.stagingFile,
this.outputFile));
// For the same reason as deleting the staging file if it already exists,
overwrite
// the output file if it already exists to prevent task retry from being
blocked.
- HadoopUtils.renamePath(this.fs, this.stagingFile, this.outputFile, true);
+ HadoopUtils.renamePath(this.fs, this.stagingFile, this.outputFile, true,
this.conf);
Review comment:
I would rather call renamePath without conf object which will take care
of the calling the other methods with new conf object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
